-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployments fail with "storybook unmet peer dependency" errors #8604
Comments
Those 3 PRs have been merged now. We should be able to deploy master and open PRs again, but we might want to redraft the release to include those recent merges? |
I'll have a go at this, and try it out. |
I re-attempted staging master with Semaphore, in staging-FR and -AU and a PR in -UK, but still observed the issue with similar errors. |
Looks to me like those "unmet peer dependency" are just warnings. Found some errors further down:
Could these be any clues? |
One problem with merging all the storybook dependencies is that after each merge, there's a conflict and we need to wait for Dependabot to rebase. That takes a while. And we usually can't wait for reviews either because by the time two reviews are in, there's a new version released. Our process doesn't work with the continuous delivery of storybook. |
Description
Deployments are broken on master after merging:
#8575
The error message points out to unmet dependencies, see:
https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/servers/uk-staging/deploys/990
Deploying commit 65e5291 (before merging the above PR) worked fine.
This was tested across staging servers.
The text was updated successfully, but these errors were encountered: