Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments fail with "storybook unmet peer dependency" errors #8604

Closed
filipefurtad0 opened this issue Dec 9, 2021 · 6 comments · Fixed by #8609
Closed

Deployments fail with "storybook unmet peer dependency" errors #8604

filipefurtad0 opened this issue Dec 9, 2021 · 6 comments · Fixed by #8609

Comments

@filipefurtad0
Copy link
Contributor

filipefurtad0 commented Dec 9, 2021

Description

Deployments are broken on master after merging:
#8575

The error message points out to unmet dependencies, see:
https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/servers/uk-staging/deploys/990

Deploying commit 65e5291 (before merging the above PR) worked fine.

This was tested across staging servers.

@jibees
Copy link
Contributor

jibees commented Dec 9, 2021

The solution could probably be to merge #8603, #8602 and #8601 at the same time (ie each one after the other) as those three projects (@storybook/serverBump, @storybook/addon-docs and @storybook/addon-controls should have the same version to work together)

@Matt-Yorkley
Copy link
Contributor

Matt-Yorkley commented Dec 10, 2021

Those 3 PRs have been merged now. We should be able to deploy master and open PRs again, but we might want to redraft the release to include those recent merges?

@filipefurtad0
Copy link
Contributor Author

filipefurtad0 commented Dec 10, 2021

I'll have a go at this, and try it out.
Thanks @Matt-Yorkley 🙏

@filipefurtad0
Copy link
Contributor Author

I re-attempted staging master with Semaphore, in staging-FR and -AU and a PR in -UK, but still observed the issue with similar errors.

@sigmundpetersen
Copy link
Contributor

Looks to me like those "unmet peer dependency" are just warnings.

Found some errors further down:

  • "stdout": "RAILS_ENV=staging environment is not defined in config/webpacker.yml"
  • "EntryModuleNotFoundError: Entry module not found: Error: Can't resolve 'babel-loader' in '/home/openfoodnetwork/apps/openfoodnetwork/releases-old/2021-12-10-134327'"

Could these be any clues?

@mkllnk
Copy link
Member

mkllnk commented Dec 12, 2021

One problem with merging all the storybook dependencies is that after each merge, there's a conflict and we need to wait for Dependabot to rebase. That takes a while. And we usually can't wait for reviews either because by the time two reviews are in, there's a new version released. Our process doesn't work with the continuous delivery of storybook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants