Ugly error message when state is missing at registration

[RachL]

Description

During registration, using the new map selector can make us easily miss the state selector. Users can go until the end of the registration process and end up with an ugly error message they do not understand.

Expected Behavior

I expect the field to work like when the localization of the address is not used: the mandatory field is highlighted.

Actual Behaviour

I see an ugly error at the end of the tunnel and I don't know what that error means. It's not translated and does not show the field which has a missing info.

Steps to Reproduce

1. Go to /register and start registering as a new enterprise
2. Write a complete address without using the state and country selectors
3. Localize the address
4. Move on to the others steps
5. Try to finish

Animated Gif/Screenshot

No error message here:

Only here:

Workaround

Select a state. But how would a user know that this is intended?

Severity

bug-s2: a non-critical feature is broken, no workaround

Your Environment

• Version used: v.3.7.1
• Browser name and version: Firefox and chrome
• Operating System and version (desktop or mobile): Both

Possible Fix

Clearly indicate to the user that state and country are mandatory, the same way we do it for the other part of the address?

[RachL]

Waiting for feedback on severity before moving to dev ready.

[mkllnk]

I would say: a critical feature broken with workaround. That's not on our scale but I think that s2 is good for this.

[andrewpbrett]

This is indirectly caused by the fact that the default country is not set correctly. Because the default country doesn't appear in the dropdown, the states do not appear in the state dropdown, and we don't do the check for whether the country requires_states is true (in the case of FR it looks like it's set to false).

So this should be fixed by #7647