-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review if we haven't missed any place where customer balances are used #6908
Comments
Places I found we use
|
@sauloperez This issue is in Code Review. Is there anything you would like us to look at, double-check? |
I'd appreciate it if you could thoroughly check the tests on that open PR. I updated the list of occurrences above for the records. I believe I didn't forget any file. Re the Payments report, @RachL and I thought it'd be best if we could fix it separately as we did with the bulk coop report so we don't make that PR too broad. It's also the report itself that is broken (it doesn't consider canceled orders) and not the balance calculation. This, however, will lead to inconsistent balances in UK and FR; the report will show a different amount compared to all other pages. We think it's an affordable trade-off given it's not a wildly used report (we still need to confirm this hypothesis with Matomo's data). |
Description
Balances are also shown on each orders payments tabs (admin side). Do we need to refactor that bit as well?
Also:
we'll need to review b9d72ce and its PR: #1468. Looks like we stopped using that file? 🔥 🔥 🔥
Acceptance Criteria & Tests
The text was updated successfully, but these errors were encountered: