Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing translation key en.spree.shipments_states.null #5945

Closed
romale opened this issue Aug 24, 2020 · 6 comments
Closed

Missing translation key en.spree.shipments_states.null #5945

romale opened this issue Aug 24, 2020 · 6 comments
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. good first issue hackathon Issues for upcoming hackathons

Comments

@romale
Copy link
Contributor

romale commented Aug 24, 2020

Description

Unfortunately I don't know how to fix it in the code.

Expected Behavior

Shipping status in client profile -> Transactions should display 'Shipping status' name

Actual Behaviour

Exception code

Steps to Reproduce

  1. Client creates order (payment by cash)
  2. Enterprise admin click on Capture (at right side of the order) in /admin/orders
    2.1 Enterprise admin opens client order via Edit and delete product item
  3. Client open /account?locale=en#/transactions#my-enterprise4
  4. "Shipping status" displays [missing "en.spree.shipments_states.null" translation]

Animated Gif/Screenshot

image

Workaround

Severity

Your Environment

  • Version used: 3.2.3
  • Browser name and version: Firefox 78.1.0esr
  • Operating System and version (desktop or mobile): Desktop

Possible Fix
@sigmundpetersen sigmundpetersen added bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. and removed bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. labels Aug 25, 2020
@RachL
Copy link
Contributor

RachL commented Aug 28, 2020 •
edited
Loading

thank you so much @romale for taking such a closer look to our translations! Don't hesitate to add the good-first-issue label when you create a translation issue: this label is followed by new developers who wants to get involved :)

@romale
Copy link
Contributor Author

romale commented Aug 28, 2020

ok @RachL :)

@RachL RachL added the hackathon Issues for upcoming hackathons label Sep 25, 2020
@lynnbright
Copy link

Hi @RachL, I would love to help with this issue for hacktoberfest 😊

@RachL
Copy link
Contributor

RachL commented Oct 1, 2020 •
edited
Loading

Hey @lynnbright ! Welcome 🎉 Please go ahead :)

Have a look at the readme and getting started sections if you haven't already!

@lynnbright
Copy link

Hi @RachL,

I found out this issue has been solved by this #6106 PR.
I think this issue can be closed. :)

@RachL
Copy link
Contributor

RachL commented Oct 16, 2020

Alright, sorry for that thanks @lynnbright !

@RachL RachL closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. good first issue hackathon Issues for upcoming hackathons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@romale @sigmundpetersen @RachL @lynnbright