Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to check out with a closed OC redirects to homepage #5571

Closed
filipefurtad0 opened this issue Jun 9, 2020 · 1 comment · Fixed by #7640
Closed

Attempting to check out with a closed OC redirects to homepage #5571

filipefurtad0 opened this issue Jun 9, 2020 · 1 comment · Fixed by #7640
Assignees
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. hackathon Issues for upcoming hackathons

Comments

@filipefurtad0
Copy link
Contributor

Description

After inserting items in the cart and while on the /shop page: if the OC closes and the customer tries to proceed to checkout, he will be redirected to the homepage instead of being redirected to the /shop page, where he can select another OC (if available).

Expected Behavior

The customer should be redirected to the /shop page, and if:

  1. no other OCs: stay on /shop page where the closed shop message is displayed (as agreed in Fix Grumpy Cat on shop page (cart with items from a closed OC) #5440, Fix Grumpy Cat on shop page (cart with items from a closed OC) #5440 (comment))
  2. if there is only one more OC, that one will be selected and displayed
  3. if there are two or more OCs, the red Oc selector will show up.

Actual Behaviour

The user is redirected to the homepage and a warning is displayed.

Steps to Reproduce

Taken from: #5501 (comment)

  1. Go to shop with (one or) several OC open and add products to the cart, but don't go any further. Stay on the shop page, leave the browser tab opened
  2. Close the OC you have just used with another browser window
  3. Come back to your tab with the shop
  4. Click on the cart on the main menu and "proceed to checkout"

Animated Gif/Screenshot

Redirection to the homepage and display of the warning:
image

Workaround

Manually select the shop (if open) and an alternative OC, if any.

Severity

bug-s4: it's annoying, but you can use it

Your Environment

  • Version used: v2.10
  • Browser name and version: Firefox 75
  • Operating System and version (desktop or mobile): Desktop Ubuntu 18.04

Possible Fix

Related to #5440.

I think this warning:
image
only appears when being redirected to the homepage. Which means, after fixing this issue it will not be displayed in any situation, as there will be no redirects to the homepage, due to OC closure. Perhaps this warning could be re-introduced? Would this be a separate papercut, for example?

@sigmundpetersen sigmundpetersen added the bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. label Jun 9, 2020
@RachL RachL added the hackathon Issues for upcoming hackathons label Sep 25, 2020
@filipefurtad0
Copy link
Contributor Author

filipefurtad0 commented May 13, 2021

This scenario is now triggering a 404 error on checkout:
https://app.bugsnag.com/open-food-france/coopcircuits/errors/609cf8d61cf2950007ce5571?event_id=609d7389007be4c96c350000&i=sk&m=nw

Peek 2021-05-13 19-59

Update: The test above relates to a slightly different scenario - clicking "checkout" on the checkout page, and hence, another issue -> #5372. The "Steps to reproduce" clearly state "Go to shop with (one or) several OC open and add products to the cart, but don't go any further".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. hackathon Issues for upcoming hackathons
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants