Invoice rendering fails due to missing address

[mkllnk]

Description

Printing invoices or viewing an invoice can fails when a billing address is missing.
https://app.bugsnag.com/yaycode/openfoodnetwork/errors/5eb7b3af2d025e0017d4e8af

Also related to missing addresses:
https://app.bugsnag.com/yaycode/openfoodnetwork/errors/5eb771788be4b200171f8fb0

Expected Behavior

Every order should have a billing address. And if the address was missing, it shouldn't crash the site.

Actual Behaviour

Some orders are missing an address and it makes it impossible to view the invoice.

Steps to Reproduce

1. ?

Animated Gif/Screenshot

Workaround

Refer to the invoice sent during checkout.

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

• Version used: 2.9.7

Possible Fix

We can make the invoice rendering more fail safe but the resulting invoice will lack the address. We then need to investigate why the address isn't there.

Error in OpenFoodNetwork

ActionView::Template::Error in app/views/spree/admin/orders/invoice.html.haml:36
undefined method `full_name' for nil:NilClass

View on Bugsnag

Stacktrace

app/views/spree/admin/orders/invoice.html.haml:36 - _app_views_spree_admin_orders_invoice_html_haml___171351979303221389_47117348228520
app/services/invoice_renderer.rb:3 - render_to_string
app/services/bulk_invoice_service.rb:13 - block in start_pdf_job
app/services/bulk_invoice_service.rb:12 - start_pdf_job
script/delayed_job:5 - <main>

View full stacktrace

Created by Maikel via Bugsnag