Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cart Problems in Production #5358

Closed
2 tasks
Matt-Yorkley opened this issue May 4, 2020 · 1 comment · Fixed by #5361
Closed
2 tasks

Cart Problems in Production #5358

Matt-Yorkley opened this issue May 4, 2020 · 1 comment · Fixed by #5361
Assignees
@Matt-Yorkley
Labels
bug-s1 The bug is stopping the platform from working, and there is no workaround. Impact of lot of users.

Comments

@Matt-Yorkley
Copy link
Contributor

Matt-Yorkley commented May 4, 2020 •
edited
Loading

We've now had a couple of downtime incidents caused by a cart bug, on multiple production servers.

If the CartController#populate endpoint (add-to-cart) returns an error code, the page will keep trying to post data to the cart endpoint again and again and again. Twice now we've had the add-to-cart endpoint return a 412 (we don't know why yet), and then it subsequently kept re-posting the data over and over, and this can cause serious problems.

More details in a thread from Friday 01 May in the (private) channel #devops-notifications

Proposed fix(es):

  • Investigate and fix whatever caused the initial 412. Cart with soft-deletion #5361
  • Fix the problem of the add-to-cart code continually spamming the endpoint with lots of requests if an error is returned. Maybe just show an error to the user, and not continually re-POST the data. Cart add error handling #5371
@Matt-Yorkley Matt-Yorkley added the s1 label May 4, 2020
@Matt-Yorkley Matt-Yorkley self-assigned this May 4, 2020
@luisramos0 luisramos0 added bug-s1 The bug is stopping the platform from working, and there is no workaround. Impact of lot of users. and removed s1 labels May 4, 2020
@luisramos0
Copy link
Contributor

I guess you meant bug-s1?
What downtime are you reffering to? The FR one a few weeks ago or something new?

@Matt-Yorkley Matt-Yorkley mentioned this issue May 4, 2020
Merged
@luisramos0 luisramos0 mentioned this issue May 5, 2020
Closed
@Matt-Yorkley Matt-Yorkley mentioned this issue May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matt-Yorkley Matt-Yorkley

Labels
bug-s1 The bug is stopping the platform from working, and there is no workaround. Impact of lot of users.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cart with soft-deletion Matt-Yorkley/openfoodnetwork
2 participants
@luisramos0 @Matt-Yorkley