After deleting a product I can't cancel an order containing that product

[lin-d-hop]

Description

Once a product has been soft-deleted it still appears in orders placed.

If I then want to cancel that order I cannot.

message = 'You need to save the variant to create a stock item before you can set stock levels.'

https://app.bugsnag.com/yaycode/openfoodnetwork-uk/errors/5da4ec3ec076fc0019b57ad6?filters[event.since][0]=30d&filters[error.status][0]=open

Expected Behavior

I want to be able to cancel orders that contain deleted products

Actual Behaviour

I cannot cancel an order than contains a deleted product

Steps to Reproduce

1. Create an order with a product
2. Delete the product
3. Cancel the order
4. Death by slug

Animated Gif/Screenshot

Workaround

Possibly by recreating the product and then cancelling the order? I haven't tested this.

Severity

bug-s3: a feature is broken but there is a workaround of adding a negative adjustment.
I'm not sure if there is a workaround. This seems to mostly impact people making test orders on the system. This doesn't seem to impact people so often once they start trading.

Your Environment

• Version used: UK 2.9.6
• Browser name and version:
• Operating System and version (desktop or mobile):

Possible Fix

[lin-d-hop]

Helston can't delete order

[RachL]

😱 and here I am deleting products for one of my users.... too late :'(

[Matt-Yorkley]

I wrote a spec related to this yesterday. When a variant is soft-deleted it's stock item is hard-deleted...

[Matt-Yorkley]

Cancelling the order obviously tries to restock the deleted variant.

[Matt-Yorkley]

I don't think there's a workaround here, but it should be fairly simple to fix.

[luisramos0]

v3 brought soft deletion to stock items, I wonder if this one is solved...

[filipefurtad0]

For a newly created on_demand variant and after placing the order with it, it seems possible to and delete this variant (which is perhaps useful information to add to #5947). After deleting this variant, it's possible to reproduce this bug by attempting to delete the order:

Bugsnag:
https://app.bugsnag.com/yaycode/openfoodnetwork-uk/errors/5f2ab6c5e81dc80018dea912?event_id=5f526da0005dec4b9a3f0000&i=sk&m=nw

[filipefurtad0]

Cancelling the order obviously tries to restock the deleted variant.

That makes sense @Matt-Yorkley . Also, it's not possible to remove or refund those items, from the previously placed orders:

This was reported here, by @Cecilia-Hn :
https://openfoodnetwork.slack.com/archives/CG7NJ966B/p1609931360401700?thread_ts=1609927942.401600&cid=CG7NJ966B

[ghost]

• Product, Variant, Stock Item, Line Item, Order when deleted or canceled must be soft deleted always so that data stays in the DB but is hidden from the admin
• Also there must be a way to un-delete (re-create) the deleted Products, Variants, Stock Item, Line Item, Order
• DELETED Product is soft deleted verified by this open_food_network_dev=# Select * from spree_products where deleted_at is NOT null;

I tried to un-delete the previously deleted product and its variants but get following error:-

[ghost]

I have fixed this on my local dev machine .. will be writing test, committing, and requesting pull ..

[filipefurtad0]

Thank you @cmittal791!
I'll assign you to this issue 👍

[ghost]

Thanks!

[meronogbai]

I will pick up this one.

[filipefurtad0]

Thank you @meronokbay for picking this up!
I've assigned you to the issue. Please let us know if you have any questions.

[meronogbai]

I won't be able to address this issue anytime soon, because life is getting hectic for me. Hopefully, someone else can pick it up.

[sigmundpetersen]

OK no worries @meronokbay . Thank you for your contributions so far, hope to see you back another time 💪

[RonellaG]

We have a producer (Enterprise 3452) that has deleted 2 products and now wants to cancel order R455001031 that contains them but cannot because of this bug.

As far as I can see there is no workaround for this. This producer sells seasonal products and this is likely to happen again for them.

For now I am going to suggest they make a negative adjustment for the value of the order and name the adjustment "Zeroing order as unable to cancel order for deleted products".

[georgethoppil]

I can take a look at this if no one else is

[sigmundpetersen]

Sure, go ahead @georgethoppil . Thank you 🎉

There was a previous attempt at this in #7622 that you could take a look at if you want.
It was only missing additional specs I think.