-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy OFN free from external data collection such as google. #5078
Comments
Is this something you'd like to work on, @albjeremias ? It would be great to move away from Google maps services, we currently have various bits of functionality that depend on them for Geocoding, searching for local food enterprises by location, and the map display page. We can definitely change that. In terms of using Stripe, we take online payments in lots of countries internationally and the alternatives there are pretty limited. We won't be moving away from Stripe any time soon. |
I could work on it.. im not savvy with ruby.. but with support i think i can tackle little bits of it! :) as of stripe, i guess its a matter of not being activated by default? |
👋... I got Open Street Map working here. The search works a bit differently than usual but if that's not a problem I could open a pull request? Although I haven't got tests working locally yet so I haven't checked if they are all passing. |
Nice! Sure, open a pull request @cillian and we'll take a look. |
Exciting!!! 😍 |
After amazing work from @cillian we have an alternative to gmaps that uses OSM for maps. In terms of Stripe, this is a very simple issue (and good for browser performance in instances that don't use stripe): we just need to not load the stripe script if the general stripe config is disable (which it is by default). This is a simple call to stripe_enabled? where the stripe script is loaded. |
I have created #5918 to address the stripe part of this issue. |
Now that #5918 is done and stripe is not there unless activated, I'd love to make OSM the default option on new installs. It's a very simple PR actually that would just invert the logic currently there to activate OSM and de-activate gmaps. |
owao.. its beautiful open source! :) sorry i was not active on this issue, but its beautiful to see! :) thank you all.. you all look really amazing! |
As we have #5542 to track down work on maps, I'm closing here. |
Hi Rachel, I think they are different asks. |
What is the problem we are solving
The problem is that after I deployed OFN with docker-compose, i went to look into the network requests and I was really disappointed to find out that there are requests to google and to stripe, both of them companies which survive from data mining/collection from users.
I also posted on the OFN forum hope you don't feel as spam, but in there i'm requesting instructions on how-to disable it, and here on please to don't set to default to track OFN users.
https://community.openfoodnetwork.org/t/i-need-help-on-configuring-ofn-without-external-data-collection/1889
Success factors = expected outcome
I expected that OFN by default does do any network request to external servers at least as default.
I known this is not a simple issue, but i believe its very important.
Useful information for inception
docker-compose using v2.8.0
The text was updated successfully, but these errors were encountered: