Products not sorted alphabetically within OC edit/create page

[RachL]

Description

As part of #4454 (comment) we introduced alphabetical ordering of products in OC admin page. However this is not working anymore.

There is no actual workaround except doing a search within the page.

Steps to Reproduce

1. Create or edit an OC for hub 922 in French prod or use Mercia Food hub in UK staging (ID 201002)
2. Observe ordering of product in both incoming and outgoing steps

Animated Gif/Screenshot

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

• Version used: v2.7.6
• Browser name and version: Firefox 73
• Operating System and version (desktop or mobile): Desktop

[luisramos0]

ok, I can explain the regression!
First of all, we dont have auto tests to verify alpha ordering, a MUST have for this issue here so this doesnt happen again...

Alpha ordering was introduced in #4454 merged on Nov 27th.
But after this we had all the work in the OC edit page coming in #4455 merged Dec 17th. From 4455 we started fetching the products from a completely different place (pagination!). Not ordered.

In this issue we can remove unnecessary product order from EnterpriseSerializer and add it where it is needed: ExchangeProductsRenderer: here for incoming and here for outgoing, or maybe here for both cases.

Good first issue only if the dev knows how to build ActiveRecord queries already.
It will be as simple as adding something like relation.order(:name) or relation.order("spree_products.name") in the correct place. And then test it in the ExchangeProductsRenderer spec.

[yihyang]

Hi there, I have created a new PR #6268 based on @luisramos0 's comment. Please let me know if there are things that needs to be updated, thanks