Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CI build #4500

Closed
sauloperez opened this issue Nov 26, 2019 · 5 comments
Closed

Fix the CI build #4500

sauloperez opened this issue Nov 26, 2019 · 5 comments
Labels
epic Group of issues tech debt

Comments

@sauloperez
Copy link
Contributor

sauloperez commented Nov 26, 2019

What we should change and why (this is tech debt)

The CI build is currently failing a crazy lot which slows us down and brings down our confidence on the tests.

Context

The only explanation that we found is that the recent upgrade to Ruby 2.2.10 made some of the already flaky tests totally unreliable.

Impact and timeline

This is totally affecting our delivery pipe and needs to be fixed ASAP.

@sauloperez sauloperez added tech debt epic Group of issues labels Nov 26, 2019
@sigmundpetersen
Copy link
Contributor

sigmundpetersen commented Nov 27, 2019

Maybe #3369 can be considered as part of this work? Improving spec reliability using timecop

@Matt-Yorkley
Copy link
Contributor

I'm wondering if now is a good time to try out CircleCI? All these flaky specs pass locally and only fail in Semaphore, which is running Ubuntu 14. We might get a faster build, too...

@luisramos0
Copy link
Contributor

🎉

@sauloperez
Copy link
Contributor Author

If I'm not mistaken #4756 was the last missing piece.

@luisramos0
Copy link
Contributor

there are few more but they dont break so often, embbeded_shopfront_spec for example.
this was a good team effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Group of issues tech debt
Projects
None yet
Development

No branches or pull requests

4 participants