Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSpec tests in custom engines are not being run #3085

Closed
kristinalim opened this issue Nov 20, 2018 · 0 comments
Closed

RSpec tests in custom engines are not being run #3085

kristinalim opened this issue Nov 20, 2018 · 0 comments
Assignees

Comments

@kristinalim
Copy link
Member

The rspec command which we use does not run tests of custom engines in engines/web.

Description

#2521 (following this discussion) introduced custom engines representing domains. That added the new "web" engine in engines/web. However, the custom engine is not covered by the rspec command which we run and is used by the official CI accounts.

Tests in custom engines should be run.

Expected Behavior

  1. GETTING_STARTED should document testing the custom engines.
  2. The Travis CI configuration file should run RSpec tests in the custom engines.

Actual Behavior

These are not the case.

Steps to Reproduce

Only for developers:

  1. Introduce a failing test in engines/web/spec/ and push to Semaphore and Travis.
  2. There are no failing tests in Semaphore and Travis.

Context

I added a new custom engine "Order Management" for #2616 and noticed that the engine tests were not covered by our CI configurations.

Severity

bug-s5: we can live with it, only a few users impacted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant