Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Products] Euro currency error. When I type a price of 5 it turns into 50 #3057

Open
sstead opened this issue Nov 15, 2018 · 7 comments
Open
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.

Comments

@sstead
Copy link

sstead commented Nov 15, 2018

Description

While testing on Katuma staging I noticed that product prices I was entering were getting saved as a different figure (e.g. if I typed 5, it would save as fifty euro 50.0 ). We then realised this was the results of the superadmin configuration setting.

image

Expected Behavior Vs Actual

When setting up an instance, it should be clear which settings I need and it shouldn't be possible to use settings which break things.

Steps to Reproduce

  1. Go to Katuma staging as superadmin
  2. in Config Set to use Euro and don't select the 'use the international...' tickbox.
  3. Go to products, set a price as 5 - see it save as 50.0
  4. Go back to Config - select the tickbox and then repeat step 3 but see that price saves as 5.0 correctly

Animated Gif/Screenshot

This video shows you how when teh config settings are wrong the pries don't save correctly https://www.useloom.com/share/c80edf4fd91f415e896070883b08d75c?focus_title=1&muted=1

Context

Instance setup- the fact that this tickbox is required in order for Euro to function, but this isn't communicated, is problematic.

Severity

s5

Your Environment

Katuma staging, PC, Chrome

@sstead sstead added the bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. label Nov 15, 2018
@myriamboure
Copy link
Contributor

Classical mistake @sstead :-) You need to go in configuration and make sure the "use international currency thing" (don't remember phrasing) is enabled. Actually I think it should be default for all instances as it works for all instances ... but anyway, check, and then close that issue ;-)

@sstead sstead added bug-s5 We can live with it... Few users are impacted. and removed bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. labels Nov 16, 2018
@sstead
Copy link
Author

sstead commented Nov 16, 2018

Thanks @myriamboure I've talked to Maikel and update the bug. I've also made a note in the superadmin guide that if you use Euro you must select the 'international' tickbox in config.

@myriamboure
Copy link
Contributor

To be precise I would say "if you use coma separator for decimals or any non dot coma separator for decimal option, you should select that"... I'm not sure it's linked only to euros. But anyway no big deal ;-)

@RachL
Copy link
Contributor

RachL commented Mar 19, 2019

So as this is set up by a configuration setting, I suggest we move this to discourse if we want to change this. So I'm closing here as Myriam suggested.

@RachL RachL closed this as completed Mar 19, 2019
@RachL
Copy link
Contributor

RachL commented Jun 6, 2019

Reopening. As maybe the checkbox does more than that.

@RachL RachL reopened this Jun 6, 2019
@romale
Copy link
Contributor

romale commented Oct 1, 2020

Thank you for this issue. I also had "Use the international..." unchecked and this strange behaviour. Now it's ok.

@filipefurtad0
Copy link
Contributor

I think I've reproduced this issue.

With these settings:

image

These values below, inputted as a prices in EUR:

0,1
0,01
0,001

Are always interpreted as 1.0 EUR. I would not expect this, as "," (comma) is set to be decimal separator.

Ticking the box below and inserting these values correctly converts them:
0,1 -> 0.1
0,01 -> 0.01
0,001 -> 0.001

I see the original post from @sstead (from Nov 15, 2018) does not have this option:

image

But these seem to have no effect whatsoever, for instance, you can input:

image

I found these settings to no effect in backoffice or shopfront - even after server/unicorn service restart.

@github-project-automation github-project-automation bot moved this to All the things in OFN Delivery board Feb 16, 2024
@sigmundpetersen sigmundpetersen changed the title Euro currency error. When I type a price of 5 it turns into 50 [Products] Euro currency error. When I type a price of 5 it turns into 50 Oct 30, 2024
@sigmundpetersen sigmundpetersen added bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. and removed bug-s5 We can live with it... Few users are impacted. labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.
Projects
Status: All the things 💤
Development

No branches or pull requests

6 participants