Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to adjust variable weights on orders #276

Closed
pmackay opened this issue Oct 27, 2014 · 4 comments
Closed

Ability to adjust variable weights on orders #276

pmackay opened this issue Oct 27, 2014 · 4 comments
Assignees

Comments

@pmackay
Copy link
Contributor

pmackay commented Oct 27, 2014

No description provided.

@pmackay pmackay added the story label Oct 27, 2014
@pmackay pmackay added this to the OFN UK v0.1 milestone Oct 27, 2014
@pmackay
Copy link
Contributor Author

pmackay commented Jan 3, 2015

Would be useful to get some input from @RohanM on how this might be tackled.

@lin-d-hop
Copy link
Contributor

Agreed. I've thought through this a little, you know, for fun, as you do... the best fit option I've come up with so far goes something like this:
Under Order tab, in the Edit button for an order...
Upon Editing an Order, an additional field for unit can be displayed and editable, eg 500g. When edited this field would then be used to adjust the price for the product in question eg price = price * newUnitValue / oldUnitValue.
As far as i can tell this will mean a new field being added to spree_line_items to store the unit, adjusted or otherwise.
Does that sound realistic? Feasible? Not fraught with nightmares or bugs?

@kirstenalarsen
Copy link
Contributor

Think we should have a chat about this one. Concern for me would then be all the places that the order is referenced (including reports etc) and either needing it to change to read from the new value, or having an option or something

Also, i'm pretty sure that changing these values doesn't recalculate the adjustments (e.g. fees) so we might need to take a look at that at the same time. The other way to do it would be to just calculate a new adjustment . . hmm. Will have a think about this. I think it could be a good one to get Rob involved in too

On 4 Jan 2015, at 2:36 am, Lynne [email protected] wrote:

Agreed. I've thought through this a little, you know, for fun, as you do... the best fit option I've come up with so far goes something like this:
Under Order tab, in the Edit button for an order...
Upon Editing an Order, an additional field for unit can be displayed and editable, eg 500g. When edited this field would then be used to adjust the price for the product in question eg price = price * newUnitValue / oldUnitValue.
As far as i can tell this will mean a new field being added to spree_line_items to store the unit, adjusted or otherwise.
Does that sound realistic? Feasible? Not fraught with nightmares or bugs?


Reply to this email directly or view it on GitHub.

@lin-d-hop lin-d-hop self-assigned this Feb 24, 2015
@lin-d-hop lin-d-hop modified the milestones: UK sprint 3, UK v0.1 Feb 24, 2015
@pmackay pmackay modified the milestones: UK sprint 3, UK sprint 4 Mar 24, 2015
@pmackay pmackay modified the milestones: UK sprint 4, UK sprint 5 Apr 13, 2015
@lin-d-hop
Copy link
Contributor

Closing as this has been merged.

Improvements have been suggested and @oeoeaio is looking at them in #568

@oeoeaio Let me know if you need me to tackle any of the improvements.

Thanks for all your help Aussies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants