Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spree Upgrade] Get shipping method from Shipment in order details #2678

Closed
luisramos0 opened this issue Sep 11, 2018 · 1 comment
Closed

[Spree Upgrade] Get shipping method from Shipment in order details #2678

luisramos0 opened this issue Sep 11, 2018 · 1 comment
Assignees
@luisramos0

Comments

@luisramos0
Copy link
Contributor

luisramos0 commented Sep 11, 2018 •
edited
Loading

Mimic what's in this commit and make sure order details works properly:
6f7c8bb
@luisramos0 luisramos0 self-assigned this Sep 11, 2018
@luisramos0 luisramos0 mentioned this issue Sep 11, 2018
Closed
@luisramos0
Copy link
Contributor Author

Actually the test introduced in the commit mentioned above is already fixed by the new OrderShippingMethod concern that contains the method order.shipping_method. So, no need to change this view.
I'm using this issue to apply the good refactor into separate partials (delivery and pickup), but I'm keeping the reference to order.shipping_method.

@luisramos0 luisramos0 mentioned this issue Sep 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luisramos0 luisramos0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sigmundpetersen @luisramos0