Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spree Upgrade] Adapt Address_Finder.last_used_ship_address to spree 2 #2663

Closed
luisramos0 opened this issue Sep 8, 2018 · 0 comments
Closed

[Spree Upgrade] Adapt Address_Finder.last_used_ship_address to spree 2 #2663

luisramos0 opened this issue Sep 8, 2018 · 0 comments
Assignees
@luisramos0

Comments

@luisramos0
Copy link
Contributor

luisramos0 commented Sep 8, 2018 •
edited
Loading

order.shipping_method relation is gone. The calculation of last_used_ship_address must use order.shipments.

See lib/open_food_network/address_finder.rb:79
and respective spec/lib/open_food_network/address_finder_spec.rb

This breaks quite a few tests in models/order_spec
@luisramos0 luisramos0 self-assigned this Sep 8, 2018
This was referenced Sep 8, 2018
Merged
Closed
@sigmundpetersen sigmundpetersen changed the title [Spree 2 Upgrade] Adapt Address_Finder.last_used_ship_address to spree 2 [Spree Upgrade] Adapt Address_Finder.last_used_ship_address to spree 2 Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luisramos0 luisramos0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luisramos0