Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spree Upgrade] Replace Order#shipping_method= #2662

Closed
luisramos0 opened this issue Sep 8, 2018 · 1 comment
Closed

[Spree Upgrade] Replace Order#shipping_method= #2662

luisramos0 opened this issue Sep 8, 2018 · 1 comment
Assignees

Comments

@luisramos0
Copy link
Contributor

luisramos0 commented Sep 8, 2018

Order#shipping_method= is gone in Spree 2.0, so any line of code that uses it in OFN will fail. We can provide the same behaviour with an adapter to spree 2 models.

Related to #2009 that handles the absence of order.shipping_method

@luisramos0
Copy link
Contributor Author

luisramos0 commented Sep 13, 2018

Instead of writing an adapter (as in #2669 ), the best solution here is probably to fix all specs that need this method. Production code may actually not require to set shipping_method like this.

These are the currently broken specs with missing shipping_method=

  • - spec/features/admin/reports_spec.rb:190 and 406
  • - spec/controllers/spree/admin/orders/customer_details_controller_spec.rb:13
  • - spec/features/admin/orders_spec.rb:152
  • - spec/requests/checkout/paypal_spec.rb:10
  • - spec/features/admin/shipping_methods_spec.rb:54
  • - spec/lib/open_food_network/customers_report_spec.rb:48
  • - spec/lib/open_food_network/order_cycle_management_report_spec.rb:72
  • - spec/models/proxy_order_spec.rb:80

@sigmundpetersen sigmundpetersen changed the title [Spree 2 Upgrade] Replace Order#shipping_method= [Spree Upgrade] Replace Order#shipping_method= Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant