Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation missing in error message / OC creation #2641

Closed
RachL opened this issue Sep 4, 2018 · 0 comments · Fixed by #2660
Closed

Translation missing in error message / OC creation #2641

RachL opened this issue Sep 4, 2018 · 0 comments · Fixed by #2660
Assignees
@kristinalim
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. good first issue

Comments

@RachL
Copy link
Contributor

RachL commented Sep 4, 2018 •
edited
Loading

Description

Found out while testing #2625
The "failed to create order cycle" message is not translated :
image.png

Steps to Reproduce

Log in as an admin on a non English instance, go to Order Cycle menu, create a new OC and try to make mistakes (don't fill all the field for instance).

(the bug is in app/assets/javascripts/admin/order_cycles/services/order_cycle.js.coffee:159 and 174)

Severity

S4

Your Environment

  • Version used: v1.18
@RachL RachL added bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. good first issue labels Sep 4, 2018
@kristinalim kristinalim self-assigned this Sep 7, 2018
@kristinalim kristinalim mentioned this issue Sep 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kristinalim kristinalim

Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Translate and fix fallback errors when creating or updating OC kristinalim/openfoodnetwork
2 participants
@kristinalim @RachL