Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spree 2 Upgrade] Refactor Order#shipping_method in checkout flow #2432

Closed
sauloperez opened this issue Jul 5, 2018 · 2 comments
Closed
Assignees

Comments

@sauloperez
Copy link
Contributor

Description

The customization we added in the payment step of the checkout flow relies on Order#shipping_method which is gone in Spree 2.0. Therefore, this logic needs to be refactored to work on that Spree version.

go_to_state :payment, :if => lambda { |order|
# Fix for #2191
if order.shipping_method.andand.delivery?
if order.ship_address.andand.valid?
order.create_shipment!
order.update_totals
end
end
order.payment_required?
}

@luisramos0 luisramos0 changed the title Refactor Order#shipping_method in checkout flow [Spree 2 Upgrade] Refactor Order#shipping_method in checkout flow Aug 24, 2018
@sauloperez
Copy link
Contributor Author

We need to check the status of this issue now that we got #2431

@luisramos0 luisramos0 self-assigned this Sep 22, 2018
@luisramos0
Copy link
Contributor

I am going to close this issue as the main problem in its description (the checkout workflow) is superbly fixed with the beautiful (and simple!) #2431
I have created #2683 which will handle the rest of the problem. I'll describe my understanding of what needs to be done in #2683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants