Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow spaces in external billing id #13073

Open
RachL opened this issue Jan 13, 2025 · 2 comments · May be fixed by #13081
Open

Don't allow spaces in external billing id #13073

RachL opened this issue Jan 13, 2025 · 2 comments · May be fixed by #13081
Assignees
@pacodelaluna
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. funded feature

Comments

@RachL
Copy link
Contributor

RachL commented Jan 13, 2025

⚠️ when working on this use #12942 Invoicing ID clockify code

Description

Following #12942 we are still allowing spaces in the ID where we shouldn't, this issue is here to fix this

Steps to Reproduce

  1. Go to /admin/enterprises/XXXX/edit as super admin
  2. Save the external billing ID with a space
  3. See you are allowed to do it

Severity

bug-s3: a feature is broken but there is a workaround
@RachL RachL added the bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. label Jan 13, 2025
@github-project-automation github-project-automation bot moved this to All the things 💤 in OFN Delivery board Jan 13, 2025
@RachL RachL mentioned this issue Jan 13, 2025
Merged
2 tasks
@pacodelaluna
Copy link
Contributor

@RachL Forgot that on former PR, I will work on this, please assign me this issue.

@RachL
Copy link
Contributor Author

RachL commented Jan 17, 2025

thanks @pacodelaluna sorry I couldn't assign you earlier, I think it's because we need contributor to comment on the issue or something 🤷‍♀

@sigmundpetersen sigmundpetersen moved this from All the things 💤 to In Progress ⚙ in OFN Delivery board Jan 17, 2025
@pacodelaluna pacodelaluna linked a pull request Jan 19, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pacodelaluna pacodelaluna

Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. funded feature
Projects
OFN Delivery board
Status: In Progress ⚙
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not allow spaces in external billing pacodelaluna/openfoodnetwork
2 participants
@pacodelaluna @RachL