[BUU] Dismissing changes is not working

[RachL]

Description

Some product are in a corrupted states, which prevent from dismissing changes and leaves some product pages stuck at the editing state.

this can be seen as super admin :

• on page 1 in staging AU
• on page 2 in staging FR

Steps to Reproduce

, We don't know how these products ended up in that state

Animated Gif/Screenshot

Workaround

none

Severity

bug-s2: a non-critical feature is broken, no workaround

[dacook]

With some experimenting I found it's due to the "None" (empty) tax category. Will have a look at what we chagned recently.

Also thinking about how we can surface unexpected errors like this better.

[dacook]

Turned this off on au_staging and it now works :D

It was already off on fr_staging. I'm not exactly sure what the problem was.
On p2 there was a variant with "None", so I updated it. 2 errors went to 1. Then I updated it back to "None". 1 error became 0.
So I suspect there was something wrong with two other records, but pressing save on them might have fixed it. I can't find any other pages with errors.

✅ So all fixed on AU and FR staging servers

I've crated a PR to help debug this kind of thing with a row line indicator:
#12479. I'll ask MArio what he thinks about the design.

I also noticed a performance problem due to a recent PR. Will raise an issue I think.

[filipefurtad0]

I wonder if this was not introduced in:
#11369

[dacook]

Still a problem, demonstrated in #12486 (comment)

[dacook]

I found the second cause of this above issue, described and proposed fix here:

• [BUU] Fix for blank dropdowns #12521

[dacook]

Just came across another example of invalid data, in ca_prod: https://openfoodnetwork.ca/admin/products/22100/edit

This product has no producer, but that's not valid. The producer dropdown is not set up to show an empty selection, and so the first option is selected.
The proposed fix will simply highlight this, like so:

Some other possible fixes are mentioned on the PR, but maybe this will be enough.

[dacook]

Although the dismiss button still doesn't work for invalid data, we decided to close because #12521 makes the invalid data a bit clearer, which helps the user to resolve by fixing the broken data.