Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUU, Orders page] Left align all table content #11610

Closed
filipefurtad0 opened this issue Sep 28, 2023 · 3 comments · Fixed by #11634
Closed

[BUU, Orders page] Left align all table content #11610

filipefurtad0 opened this issue Sep 28, 2023 · 3 comments · Fixed by #11634
Assignees
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. good first issue hackathon Issues for upcoming hackathons

Comments

@filipefurtad0
Copy link
Contributor

filipefurtad0 commented Sep 28, 2023

Description

On the new orders page (BUU - Backoffice UI Uplift), the table content on the orders table is centered, which creates sort of a mismatch with column titles

Expected Behavior

Table header should have the same text orientation as table contents - all should be left aligned

Actual Behaviour

Table header does not have the same text orientation as table contents - it's currently oriented to the left, while the table contents have centered orientation.

Steps to Reproduce

Logged in as superadmin, enable the BUU feature:

  1. Visit admin/feature-toggle/features/admin_style_v3
  2. Select Fully Enable

As a Hub admin or Superadmin:
3. Visit the orders page - admin/orders
4. Notice the mismatch on the table header vs table contents orientation

Animated Gif/Screenshot

image

Workaround

None needed.

Severity

bug-s4: it's annoying, but you can use it

Your Environment

  • Version used: v4.4.13
  • Browser name and version: tested for Firefox 117
  • Operating System and version (desktop or mobile): Ubuntu 22.04

Possible Fix

@filipefurtad0 filipefurtad0 added bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. hackathon Issues for upcoming hackathons good first issue labels Sep 28, 2023
@RachL RachL removed the hackathon Issues for upcoming hackathons label Sep 28, 2023
@mariocarabotta
Copy link
Collaborator

good find. I would recommend to left align the table content rows if it's similar effort. it would make the table more legible

@RachL RachL changed the title [BUU, Orders page] Table header not centered [BUU, Orders page] Left aligne all table content Oct 2, 2023
@RachL RachL changed the title [BUU, Orders page] Left aligne all table content [BUU, Orders page] Left align all table content Oct 2, 2023
@RachL RachL transferred this issue from openfoodfoundation/wishlist Oct 2, 2023
@github-project-automation github-project-automation bot moved this to To triage (By the maintainers) in Welcome New Developers! Oct 2, 2023
@github-project-automation github-project-automation bot moved this to All the things in OFN Delivery board Oct 2, 2023
@RachL RachL added the hackathon Issues for upcoming hackathons label Oct 2, 2023
@lauriejefferson
Copy link
Contributor

I would like to work on this issue.

@sigmundpetersen
Copy link
Contributor

Yeah sure @lauriejefferson , thank you! 🙂 I'll assign you

@sigmundpetersen sigmundpetersen moved this from To triage (By the maintainers) to In progress in Welcome New Developers! Oct 3, 2023
@drummer83 drummer83 assigned drummer83 and unassigned drummer83 Oct 13, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in Welcome New Developers! Oct 13, 2023
@github-project-automation github-project-automation bot moved this from All the things to Done in OFN Delivery board Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. good first issue hackathon Issues for upcoming hackathons
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants