Can't proceed to checkout if order total is equal to 0 (blocked at details step)

[Cecilia-Hn]

Description

When a shop displays products at zero euros and a customer wants to shop products at zero euros from this shop, the tool loops on step 1 of spit checkout.

Expected Behavior

Client should be able to shop products at zero euros

Actual Behaviour

Shop displays products at zero euros
Customer add products at zero euros to his cart
Customer selects "Checkout"
Customer is stuck on the 1st step "1-Your details"

How to test

1. As a shop manager, create a shop that sells a 0 product
2. As a customer, add this product to cart
3. Proceed to checkout
4. On details step, fill the form
5. Submit
6. See that you're redirected to the details page.

I've create a shop, can be easily reproduced: https://staging.coopcircuits.fr/free-products-shop/shop

Workaround

No free products on a shop

Severity

S3
It's a real bug, but it concerns a rare use of the platform, so I would say S3

[jibees]

Notes for developper: It's probably related to the order state, that is not able to be set to payment if there is only product at 0 and one is then redirected to details step when trying to proceed to payment step.

openfoodnetwork/app/models/spree/order.rb

Lines 23 to 26 in 6e34f61

	go_to_state :payment, if: ->(order) {
	order.update_totals
	order.payment_required?
	}

openfoodnetwork/app/models/spree/order.rb

Lines 207 to 209 in 6e34f61

	def payment_required?
	total.to_f > 0.0 && !skip_payment_for_subscription?
	end

[jibees]

Note that this could probably happen if product is not equal to 0 but if you have paid products + vouchers (or negative fees) so that it brings the order total to 0.

[jibees]

Possible fix:

diff --git a/app/models/spree/order.rb b/app/models/spree/order.rb
index 40dfbcb093..b3cee9f775 100644
--- a/app/models/spree/order.rb
+++ b/app/models/spree/order.rb
@@ -205,7 +205,7 @@ module Spree
     #   Subscriptions place orders at the beginning of an order cycle. They need to
     #   be completed to draw from stock levels and trigger emails.
     def payment_required?
-      total.to_f > 0.0 && !skip_payment_for_subscription?
+      !skip_payment_for_subscription?
     end
 
     # Returns the relevant zone (if any) to be used for taxation purposes.

Will submit a draft PR, and see how specs goes...

[filipefurtad0]

#11135 fixes this 🎉 closing!

Please note that orders with total = 0 will appear on the payments report like so:

I think the none string is not translated, but I'm not even sure we should have this line on the report. Happy for feedback on this - discussion here.