Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[White Label] Add configuration into a single model/table instead of having many columns #10749

Open
jibees opened this issue Apr 25, 2023 · 1 comment

Comments

@jibees
Copy link
Contributor

jibees commented Apr 25, 2023

What we should change and why (this is tech debt)

This is an open discussion but adding many attribute/columns to enterprise model/table doesn't seems fine to me: adding columns to a so used table isn't good for performance.
That's why I propose to add model/table for white labeling configuration instead of having severable attributes.

Table name: WhiteLableConfiguration
columns:

  • enterprise_id: FK to enterprise.id
  • hide_ofn_navigation, :boolean, null: false, default: false
  • ....

Context

This came up when developing White labelling.

Impact and timeline

@jibees jibees self-assigned this Apr 25, 2023
@mkllnk
Copy link
Member

mkllnk commented Apr 25, 2023

I agree. A separate model for the configuration is the best solution.

@sigmundpetersen sigmundpetersen changed the title WhiteLabel: Add configuration into a single model/table instead of having many columns [White Label] Add configuration into a single model/table instead of having many columns May 24, 2023
@jibees jibees removed their assignment Sep 21, 2023
@github-project-automation github-project-automation bot moved this to All the things in OFN Delivery board Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: All the things 💤
Development

No branches or pull requests

2 participants