[Split checkout] Users without shipping address are not able to reach step2 if there is only a pickup shipping method in step 1

[RachL]

Description

See user info here: https://openfoodnetwork.slack.com/archives/C01V3KW8RSM/p1677251613703549?thread_ts=1677249745.577039&cid=C01V3KW8RSM

when this user tries to go to payment step, they see an error message saying they should add a shipping address. yet the only shipping method is a pickup one (no shipping address required).

couldn't reproduce on staging, couldn't reproduce with my US super admin account 🤔

Steps to Reproduce

1. Go to https://openfoodnetwork.net/open-food-network-usa/shop#/shop
2. Go to /cart
3. Try to go to payment step
4. See error message on shipping address

Animated Gif/Screenshot

See videos here:

https://openfoodnetwork.slack.com/archives/C01V3KW8RSM/p1677249745577039

Workaround

None

Severity

bug-s2: a non-critical feature is broken, no workaround

Your Environment

• Version used: v4.1.25
• Browser name and version: Firefox and chrome
• Operating System and version (desktop or mobile): Windows and ubuntu

[drummer83]

See #9056.

[rioug]

I managed to reproduce the issue by "massaging" my data , you need to make sure you have Customer with no shipping address when on the checkout page, then the error will trigger. I'll look at fixing it tomorrow

[audez]

Finally it was it..
The issue is big because it impacts all customers who previously checked out on legacy but didn't choose to save their address, and want to choose a pickup method. All those who are registered in "Customers" list but don't have a shipping address.

It was hard to reproduce/understand because there must have been a recent change: if you take a fresh account today and do legacy (or split) checkout without choosing "Save shipping address", it will save the shipping address anyways. This is a new bug i guess (and on split checkout, even if you don't finalize the order the customer is added to the shop list as long as you reached step 2).

So to reproduce the case you have to:

• Create a fresh account
• As an admin of a shop with a pickup method, in "Customer" tab, register the mail (don't put the shipping address)
• As the customer, checkout on split checkout on this shop with pickup method

Workarounds are:

• Set the shipping address as an admin in Customers tab
• Checkout on a "Delivery" shipping method then come back
• Switching shipping method from "Pickup" to "Delivery"

They will all allow to update the shipping address.

The reason of the 422 error is: when sending the request the shipping address fields are empty and the request fails

It looks like normally, for pickup methods, the shipping address is inherited from the billing address - you can see it by doing a simple split checkout:
Request URL: https://coopcircuits.fr/checkout/details

But it seems that for registered user without shipping address, the shipping address is not inherited and will be empty. This would be the case for our users.

For the tests it seems useless to delete a customer info in Customers tab, because the info remains saved in db.

PS: sorry for the misleading #9056 (comment), now i can see in the screens that the failed requests was only when at least one field of shipping address was empty. There was no link with order[bill_address_attributes][id]