Pagination in BOM not aggregating results from quick search field

[filipefurtad0]

Description

Related to #10375.

If a search is made on BOM and the results are filtered through the quick search field, then these are spread out between different pages.

Expected Behavior

Pagination should consider the results from the quick search field.

Actual Behaviour

Pagination is not considering the results from the quick search field.

Steps to Reproduce

1. Visit BOM on a hub with plenty of line items / orders so that these are spread out through several pages
2. Use the quick search for a name or line item
3. Notice these are appearing in the respective pages, and that the pagination numbering is inconsistent.

Animated Gif/Screenshot

searching for "name" - which in this case can be a customer name, but also a line item:

Page 1

Page 2

Page 3

Workaround

Navigate through the different pages, to see the results from the quick search field.

Severity

I think all results are appearing. bug-s4?

Your Environment

• Version used: current master d5b0891
• Browser name and version: Firefox 109
• Operating System and version (desktop or mobile): Ubuntu 22.04

Possible Fix

[jibees]

Yep, this is more a searching/filtering for the results of the current page (ie. displayed) than a search that refresh data. That's why this input is below the "filter results" button and near other actions that change the display of the current results. Actually, I'm not sure this is a bug... Maybe it's not clear enough? Because yes, due to new pagination, this could be disturbing for user that used to use the interface before...

[drummer83]

Just wanted to mention that the displayed number of results and the 'viewing' number need to be adjusted as well, when working on this.

[RachL]

@jibees I think it's also disturbing for users that compare this to the regular orders page. What would be your estimate to move the quick search above the filter and make it work with pagination? (I'm trying to see if we are looking at papercut material here).

[jibees]

Regarding the regular orders page (ie. /admin/orders), I cannot see any search. Am I missing something?

On products page, we do have a search:

I guess it's about 1 day to add this kind of search into the BOM page and remove this view filtering component.

[RachL]

ooopsy yes I meant product page 🙈 But you still have many search fields like name where you can type anything

[jibees]

One comment.
I started working on it, but I'm wondering what kind of search we want to create.

• Previously: we searched through all attributes a line item has, this was pretty easy because all data were present, consolidated, and displayed.
• What we have now: we have a paginated displaying that request server for each page and the conciliated data with the associated order (what basically do BOM: Ensure orders informations are loaded for each line items #10375)

So what?

• Adding a search filter that search for on line_items attribute (like it's already done for Product and its name) is pretty easy:

• Searching for all attributes that build a displayed line items is not that easy.

Then, I'm wondering if there can have a quick win: user mostly search through insert a line item attribute here, so let's do that quick win for now, and open an issue to improve that search.

What do you think?

[jibees]

(Actually maybe I'm wrong and we could create a search query that search for all attributes ; I should investigate more)

_EDIT: _ since I leave for hollidays in few hours, I've open a draft PR that actually solves a bit the issue we have here.