Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Price privacy warning" not correctly displayed #6363

Open
monsieurtanuki opened this issue Feb 8, 2025 · 8 comments · May be fixed by #6402
Open

"Price privacy warning" not correctly displayed #6363

monsieurtanuki opened this issue Feb 8, 2025 · 8 comments · May be fixed by #6402

Comments

@monsieurtanuki
Copy link
Contributor

What

  • The very first time we add a price, there's a warning dialog displayed ("people may know what you buy and where, are you OK with that?")
  • The display of that warning dialog isn't correctly displayed, as there's an overflow.

Steps to reproduce the behavior

  1. Uninstall and reinstall the app
  2. Create a price (therefore, for the first time)
  3. You'll see the warning dialog
  4. At least in debug mode, the overflow is explicit

Expected behavior

Clean display.

Screenshot

Image

Logs

══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown during layout:
A RenderFlex overflowed by 3.2 pixels on the bottom.

The relevant error-causing widget was:
  Column
  Column:file:///C:/Users/fabri/StudioProjects/smooth-app/packages/smooth_app/lib/generic_lib/bottom_sheets/smooth_botto
  m_sheet.dart:360:16

To inspect this widget in Flutter DevTools, visit:
http://127.0.0.1:9101/#/inspector?uri=http%3A%2F%2F127.0.0.1%3A59570%2FOrBMqiXqILA%3D%2F&inspectorRef=inspector-0

The overflowing RenderFlex has an orientation of Axis.vertical.
The edge of the RenderFlex that is overflowing has been marked in the rendering with a yellow and
black striped pattern. This is usually caused by the contents being too big for the RenderFlex.
Consider applying a flex factor (e.g. using an Expanded widget) to force the children of the
RenderFlex to fit within the available space instead of being sized to their natural size.
This is considered an error condition because it indicates that there is content that cannot be
seen. If the content is legitimately bigger than the available space, consider clipping it with a
ClipRect widget before putting it in the flex, or using a scrollable container rather than a Flex,
like a ListView.
The specific RenderFlex in question is: RenderFlex#05279 relayoutBoundary=up9 OVERFLOWING:
  creator: Column ← DecoratedBox ← ClipRRect ← SmoothModalSheet ←
    NotificationListener<DraggableScrollableNotification> ← DefaultTextStyle ←
    AnimatedDefaultTextStyle ← _InkFeatures-[GlobalKey#e57dc ink renderer] ←
    NotificationListener<LayoutChangedNotification> ← CustomPaint ← _ShapeBorderPaint ← PhysicalShape
    ← ⋯
  parentData: <none> (can use size)
  constraints: BoxConstraints(0.0<=w<=411.4, 0.0<=h<=500.8)
  size: Size(411.4, 500.8)
  direction: vertical
  mainAxisAlignment: start
  mainAxisSize: min
  crossAxisAlignment: center
  verticalDirection: down
  spacing: 0.0
@monsieurtanuki
Copy link
Contributor Author

That would even look like a dark pattern...

Image

@monsieurtanuki
Copy link
Contributor Author

Similar problem: sometimes we don't finish sentences.
Image

@monsieurtanuki
Copy link
Contributor Author

And also

Image

Image

Image

@chetanr25
Copy link
Contributor

chetanr25 commented Mar 9, 2025

I’m looking to contribute. Can i pick up the issue.

@monsieurtanuki
Copy link
Contributor Author

I’m looking to contribute. Can i pick up the issue.

@chetanr25 Unfortunately not, as @YoussefMoRabie is already working on it in #6402.
For some reason I cannot "officially" assign @YoussefMoRabie, maybe too recent contributor, I don't know.
You'll have to find another issue ;)

@chetanr25
Copy link
Contributor

Got it! thanks for letting me know!

@aikansh008
Copy link

Hello sir can you please assign this issue to me

@monsieurtanuki
Copy link
Contributor Author

@aikansh008 As you can read in a previous comment, this issue is already virtually assigned to @YoussefMoRabie.

@YoussefMoRabie is already working on it in #6402. For some reason I cannot "officially" assign @YoussefMoRabie, maybe too recent contributor, I don't know. You'll have to find another issue ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Status: 💬 To discuss and validate
Development

Successfully merging a pull request may close this issue.

4 participants