Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: missing assets on presskit page - openfoodfacts-web not exposed ! #9859

Closed
Valimp opened this issue Mar 1, 2024 · 6 comments
Closed

bug: missing assets on presskit page - openfoodfacts-web not exposed ! #9859

Valimp opened this issue Mar 1, 2024 · 6 comments
Assignees
@alexgarel
Labels
🎯 P1 static content This lives at https://github.com/openfoodfacts/openfoodfacts-web

Comments

@Valimp
Copy link
Collaborator

Valimp commented Mar 1, 2024

What

Missing lot of assets on presskit page

Steps to reproduce the behavior:

  1. Go to : Presskit page
  2. Scroll down
  3. See some assets missing

Expected behavior

These assets simply don't exist

Screenshots

Capture d’écran 2024-03-01 à 14 16 10 Capture d’écran 2024-03-01 à 14 16 25

I made a list of missing images and svg :

https://world.openfoodfacts.org/images/eco-score-logos/ecoscore-b.svg

https://static.openfoodfacts.org/images/misc/mobileapp/new_openfoodfacts_app_en_light_3_screenshots.png
https://world.openfoodfacts.org/images/logos/logo-variants/MONO_CMJN_VERTICAL_WHITE_BG_OFF.svg
https://world.openfoodfacts.org/images/eco-score-logos/ecoscore-bw-a.svghttps://world.openfoodfacts.org/images/eco-score-logos/ecoscore-bw-b.svghttps://world.openfoodfacts.org/images/eco-score-logos/ecoscore-bw-c.svghttps://world.openfoodfacts.org/images/eco-score-logos/ecoscore-bw-d.svghttps://world.openfoodfacts.org/images/eco-score-logos/ecoscore-bw-e.svg
https://world.openfoodfacts.org/illustrations/un-sdg-logos/EN_SDG_Goals_03.pnghttps://world.openfoodfacts.org/illustrations/un-sdg-logos/EN_SDG_Goals_12.pnghttps://world.openfoodfacts.org/illustrations/un-sdg-logos/EN_SDG_Goals_13.pnghttps://world.openfoodfacts.org/illustrations/un-sdg-logos/EN_SDG_Goals_14.pnghttps://world.openfoodfacts.org/illustrations/un-sdg-logos/EN_SDG_Goals_15.pnghttps://world.openfoodfacts.org/illustrations/un-sdg-logos/EN_SDG_Goals_17.png
https://world.openfoodfacts.org/images/misc/nutriscore/nutriscore-white-d.svg
https://world.openfoodfacts.org/cop26/podcast/podcast-thumbnail-en.jpghttps://world.openfoodfacts.org/cop26/podcast/podcast-thumbnail-fr.jpgAll podcast icons

https://world.openfoodfacts.org/images/eco-score-logos/ecoscore-b.svg
https://static.openfoodfacts.org/images/misc/mobileapp/new_openfoodfacts_app_en_light_3_screenshots.png
https://world.openfoodfacts.org/images/logos/logo-variants/MONO_CMJN_VERTICAL_WHITE_BG_OFF.svg
https://world.openfoodfacts.org/images/eco-score-logos/ecoscore-bw-a.svg
https://world.openfoodfacts.org/images/eco-score-logos/ecoscore-bw-b.svg
https://world.openfoodfacts.org/images/eco-score-logos/ecoscore-bw-c.svg
https://world.openfoodfacts.org/images/eco-score-logos/ecoscore-bw-d.svg
https://world.openfoodfacts.org/images/eco-score-logos/ecoscore-bw-e.svg
https://world.openfoodfacts.org/illustrations/un-sdg-logos/EN_SDG_Goals_03.png
https://world.openfoodfacts.org/illustrations/un-sdg-logos/EN_SDG_Goals_12.png
https://world.openfoodfacts.org/illustrations/un-sdg-logos/EN_SDG_Goals_13.png
https://world.openfoodfacts.org/illustrations/un-sdg-logos/EN_SDG_Goals_14.png
https://world.openfoodfacts.org/illustrations/un-sdg-logos/EN_SDG_Goals_15.png
https://world.openfoodfacts.org/illustrations/un-sdg-logos/EN_SDG_Goals_17.png
https://world.openfoodfacts.org/images/misc/nutriscore/nutriscore-white-d.svg
https://world.openfoodfacts.org/cop26/podcast/podcast-thumbnail-en.jpg
https://world.openfoodfacts.org/cop26/podcast/podcast-thumbnail-fr.jpg
All podcast icons
@alexfauquette
Copy link
Member

This is for the server repo I assume, not hunger game 🤔 😉

@Valimp
Copy link
Collaborator Author

Valimp commented Mar 2, 2024

This is for the server repo I assume, not hunger game 🤔 😉

My bad 😅

@Valimp Valimp closed this as not planned Won't fix, can't repro, duplicate, stale Mar 2, 2024
@teolemon
Copy link
Member

teolemon commented Mar 2, 2024 •
edited
Loading

@Valimp you can move the issue to another repo if you have enough privileges

@alexfauquette alexfauquette reopened this Mar 2, 2024
@alexfauquette alexfauquette transferred this issue from openfoodfacts/hunger-games Mar 2, 2024
@alexfauquette
Copy link
Member

you can move the issue to another repo

Done 👍

@alexgarel alexgarel changed the title bug: missing assets on presskit page bug: missing assets on presskit page - openfoodfacts-web not exposed ! Mar 4, 2024
@alexgarel
Copy link
Member

The problem is much more important than though: all of openfoodfacts-web/html is not exposed yet !

I will handle this.

@teolemon teolemon added the static content This lives at https://github.com/openfoodfacts/openfoodfacts-web label Mar 18, 2024
@teolemon teolemon assigned teolemon and alexgarel and unassigned teolemon Apr 1, 2024
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@alexgarel
Copy link
Member

This was done in #9865

@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Apr 29, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Hunger Games (new) Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexgarel alexgarel

Labels
🎯 P1 static content This lives at https://github.com/openfoodfacts/openfoodfacts-web
Projects
Hunger Games (new)
Archived in project
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexgarel @teolemon @alexfauquette @Valimp