-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: large update on processed meats #9828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @OpenChris!
I made few suggestions, mostly about starting with "en:" I would be super if you could apply them.
mostly add en: tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OpenChris
I will approve but before to merge please consider the following changes if you agree (I don't know Spanish at all so I will let you decide if it is better or not):
en:loins
es:lomo<en:Pork
<en:loins
en:Pork loin
fr:Longe de porc
es:Lomo de cerdo
(etc.)<en:Pork loin
en:Cured pork loin<en:Pork loin
en:stuffed pork loin<en:stuffed pork loin
en:lomo embuchado
es:lomo embuchado<en:Pork loin
en:cured pork loin
Because it seems to me that lomo is loin. Also, lomo embuchado may be same in English: https://www.wikidata.org/wiki/Q1868800
Thanks @benbenben2 - Wikidata doesn't place pork loin as a child of the more general 'loin' category. |
As for the word 'Lomo' without any precision, it is really always associated with the cured version of the loin in shops. I suggest we keep it as a tag for Lomo embuchado since it is actually what you buy by default. I'm fine if s.o. has a better rule of course. I'm not an expert in spanish ;-) |
Quality Gate passedIssues Measures |
@OpenChris thanks for your work 🎉 @benbenben2 thanks for validating :-) |
* taxonomy: large update on processed meats * fix: parent typo * taxonomy: fixes from @benbenben2 comments mostly add en: tags * taxonomy: final precisions on Lomo
Large update on "Charcuteries" - processed meats