fix: missing_translations_in_dq_button

[benbenben2]

What

@teolemon, I did not know what it means "missing translations in the Data Quality action button", I had to search.

In the provided example, there is another facet where the button is as expected. Let's look at it first.
We can find reference to this "action" in

• data_quality.txt -> fix_action:en: add_origins - BUT not for all facets ( EcoScore - packaging - Packaging data missing, for example)

• Products.pm -> add_origins + url suffix

• en.po -> msgtxt "action_add_origins" + message in the box

origins_of_ingredients.tt.json -> 
	    	"element_type": "action",
            "action_element": {
                "html": `[% lang("action_add_origins") %]`,
                "actions": [
                    "add_origins",
                ]
            }

however, more generic in data_quality_tags.tt.json:

            [% IF fix_action != 'undef' %]
                {
                    "element_type": "action",
                    "action_element": {
                        "html": `[% lang(action_name) %]`,
                        "actions": [
                            "[% fix_action %]",
                        ]
                    },
                },

for serving quantity facet.

• we have in data_quality.txt

en:Serving quantity defined but quantity undefined
fix_action:en: add_quantity

• we also have add_quantity url define in Products.pm

• However it is missing in en.pot. Which make sense because it is where we have translations (now, I understand message from @teolemon :-) )

• so (following advice from @alexgarel in a previous PR: feat: allow_longer_user_name #9588 (comment)) we will add, in common.pot only.

msgctxt "action_add_quantity"
msgid "Add quantity for the product"
msgstr "Add quantity for the product"

3. test. It does not work. Try also to add the translation in en.po. Yes, it works!

Screenshot

Related issue(s) and discussion

• Fixes Missing translations in the Data Quality action button #9783

[stephanegigandet]

Thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud