feat: revamped taxonomy sort script #9818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to really sort everything
github-actions
bot
added
the
🧬 Taxonomies
github-actions
bot
added
the
GitHub Actions
benbenben2
reviewed
Feb 26, 2024
Comment on lines
+243
to
+246
| # TODO: add check_taxonomies when taxonomies ready | ||
|
|
||
| lint: lint_perltidy | ||
| # TODO: add lint_taxonomies when taxonomies ready |
There was a problem hiding this comment.
Is it dependent on this: #9843 ?
There was a problem hiding this comment.
Not really, but the other one is now merged.
It's more when taxonomy will be sorted !
| return $a_prefix cmp $b_prefix if ($a_prefix ne $b_prefix); | ||
| } | ||
| return 0 if ($a eq $b); | ||
| # en takes precedence over all others |
There was a problem hiding this comment.
One issue is that for some taxonomies, we have chosen to have the xx: or the zz: entry be the canonical name, so that the canonical id does not change if we need to change the main English name. It's the case for nutrients.txt and units.txt
There was a problem hiding this comment.
fixed, I now never change first entry (for now). I think it's a different decision to change the main language !
stephanegigandet
approved these changes
Mar 7, 2024
erronously removed !
|
john-gom
pushed a commit
that referenced
this pull request
May 24, 2024
to really sort everything (within an entry)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to really sort everything (within an entry)