Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: add origins translations #9801

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

ArturLange
Copy link
Contributor

What

Added Polish origin translations for some of the most popular origins

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 📍 Origins Origins are used for Eco-Score computation. We want to have structured origins. labels Feb 15, 2024
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet
Copy link
Contributor

@ArturLange it seems there is the same translation for both UK and Great Britain, could you change one of them?

ERROR - pl:wielka-brytania already is associated to en:united-kingdom (origins) - pl:wielka-brytania cannot be mapped to entry en:great-britain

@ArturLange
Copy link
Contributor Author

I thought that might be a problem, but I couldn't find it in origins.txt. Should be fixed now.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (dc04d18) 49.54% compared to head (6cdd294) 49.56%.
Report is 40 commits behind head on main.

Files Patch % Lines
lib/ProductOpener/KnowledgePanels.pm 0.00% 26 Missing ⚠️
lib/ProductOpener/Display.pm 5.55% 16 Missing and 1 partial ⚠️
lib/ProductOpener/Web.pm 0.00% 12 Missing ⚠️
lib/ProductOpener/DataQualityFood.pm 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9801      +/-   ##
==========================================
+ Coverage   49.54%   49.56%   +0.02%     
==========================================
  Files          67       67              
  Lines       20650    20731      +81     
  Branches     4980     4993      +13     
==========================================
+ Hits        10231    10276      +45     
- Misses       9131     9167      +36     
  Partials     1288     1288              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephanegigandet
Copy link
Contributor

I thought that might be a problem, but I couldn't find it in origins.txt. Should be fixed now.

Thank you!

@stephanegigandet stephanegigandet merged commit 534c311 into openfoodfacts:main Feb 16, 2024
12 checks passed
@ArturLange ArturLange deleted the polish-origins branch February 16, 2024 11:39
john-gom pushed a commit that referenced this pull request May 24, 2024
* taxonomy: add origins translations

* Fix Great Britain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Origins Origins are used for Eco-Score computation. We want to have structured origins. 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants