fix: failing nutriment persize serving test #873
Conversation
davidpryor
changed the title
There was a problem hiding this comment.
Thank you @davidpryor for finding and fixing that bug!
I have comments regarding the code itself though, regarding maintainability.
Please have a look at them and feel free to tell me what you think.
* consolidated tests
There was a problem hiding this comment.
Thank you @davidpryor for your changes!
I cannot see the added value of your additional "Test saving food with PerSize.serving Nutrients" test. Now that you loop in the already existing "confirm that nutrient fields are saved" test for all PerSize values, we don't need to copy/paste the test, right?
Explain that to me or fix that, and I'll approve your PR.
Less important: if you used a const map for initial values, you would never have potential discrepancies between the nutrient values you set and the list of nutrients you check:
const Map<Nutrient, double> rootNutrientValues = <Nutrient, double>{
Nutrient.energyKJ: 365,
Nutrient.carbohydrates: 12,
Nutrient.proteins: 6,
Nutrient.fat: 0.1,
};E.g. using rootNutrientValues.keys.
- import 'package:openfoodfacts/openfoodfacts.dart'; + import 'model/per_size.dart'; Co-authored-by: monsieurtanuki <[email protected]>
Co-authored-by: monsieurtanuki <[email protected]>
Co-authored-by: monsieurtanuki <[email protected]>
I agree. Just missed deleting it. |
What
Fixed inability to send nutrients to server that were tagged with PerSize.serving
Fixes bug(s)
#872