Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes don't show up for Hebrew (RTL) #4250

Open
teolemon opened this issue Sep 20, 2021 · 5 comments
Open

Attributes don't show up for Hebrew (RTL) #4250

teolemon opened this issue Sep 20, 2021 · 5 comments

Comments

@teolemon
Copy link
Member

What

  • Attributes don't show up for Hebrew (RTL)

Part of

Screenshot

image

@yarons
Copy link

yarons commented Sep 22, 2021

Also the downwards arrows should be aligned to the left instead of to the right.

@mcarare
Copy link
Contributor

mcarare commented Oct 5, 2021

This does not look like an RTL issue, rather the attributes are empty for the selected language.

@yarons
Copy link

yarons commented Oct 5, 2021

@mcarare Hebrew translation in Crowdin is 99% complete, the remaining strings are mostly links so it's probably not related, anything I should translate further? Anything that should be changed elsewhere?

BTW there is an additional RTL problem, the downwards arrow are to the right instead of to the left.

@mcarare
Copy link
Contributor

mcarare commented Oct 6, 2021

@yarons Not sure if it is a translation problem or the problem is in the code here:

fun getAttributeGroups(language: String): List<AttributeGroup> {
.
It needs to be investigated further because the name is returned as an empty string. But attributes not showing it is not an RTL issue.

@yarons
Copy link

yarons commented Oct 6, 2021

It's weird because this is an iterative function and there are several items on screen, maybe the font is at the same color as the background or something like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants