Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize the screen bettter in the Contribution Assistant (genai) #1082

Closed
thibaultmol opened this issue Dec 4, 2024 · 3 comments
Closed
Labels

Comments

@thibaultmol
Copy link

Problem

it would be nice if you could have the image be bigger, my screen allows for it. a lot of empty space right now

Proposed solution

scale the image based on viewport size.

Image

@raphodn raphodn added the GenAI label Dec 4, 2024
@TTalex
Copy link
Collaborator

TTalex commented Dec 4, 2024

I'm a bit hesitant on which size to use as a limit.

The current behavior is to try to fit the image in its parent container width, which is itself half the page, unless the image exceeds 400px in height.

We could skip the 400px constraint, but for large screens and tall images (such as vertical photos), this leads to a huge image with lots of scrolling to do.

If the expected UI for most desktop devices is to have the full picture in frame, as well as the processing button and the footer, we could replace the 400px constraint with something more dynamic, like the height of the window minus the height of the different headers and footers, e.g. window.innerHeight - 500. Maybe keeping a minimum for smaller screens where scrolling is expected.

But to be honest, with this last solution, when you consider 400px for the image, 500px for header and footer content, 150px for browser overhead and 50px for an operating system bottom bar. You're already at 1100px, which is higher than ~95% of known desktop screens size.

So maybe the default behavior for most people should be to scroll a bit, to maximize the chance of an image big enough for processing ?

@thibaultmol
Copy link
Author

thibaultmol commented Dec 5, 2024

I don't know what the right values should be. But this is personally the size i would like the image to be at, on a screen of this resolution.

Currently:
Image

What i would like to see:
Image
(maybe have a gradient on the bottom of the div at the bottom of the second step)

the footer takes too much space

and the "2. Check the readability of labels " should be in it's own box with it's own scrollbar I think.

So the page stays static but the second step has a scrollbar

(i know it's more complicated than this, i'm just trying to express how i personally think the end result should be)

@TTalex
Copy link
Collaborator

TTalex commented Jan 23, 2025

Closing this, not sure when we fixed it, but the image should be way bigger now. We also altered the look of the labels and the steps :)

Thanks again for the feedback !

@TTalex TTalex closed this as completed Jan 23, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in 💸 Open Prices Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants