-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #264
Update dependencies #264
Conversation
recommonmark is obsolete and has been replaced by myst-parser, which bundles docutils and parses Markdown tables natively, removing the need for these extensions
The only blocking point left is ambiguous references in the docstrings generated from Core, which can only be fixed there. I opened openfisca/openfisca-core#1128. Once it is merged, jobs here should be rerun. |
I'm still getting an error, the same than in CI:
|
Thanks @maukoquiroga! Indeed, this error appeared after the other ones were fixed by openfisca/openfisca-core#1128. It seems to have been “shadowed” somehow by the previous ones. |
@MattiSG This problem was being ignored, that's all. So either:
To reproduce I just did a clean installation : pyenv virtualenv 3.8.13 blabla-3.8.13
make install
make test Be sure to keep your venv isolated from others. I can't fix it now as it demands more cognitive effort that I can afford after ~ 12h of train, but I could yes. |
Well it looks not just |
@MattiSG It looks better now: it seems to me we need to fix outdated docstrings and use either Google or Numpy style —currently our styleguide recommends Google style. Can you reproduce now?
|
Thanks @maukoquiroga for your commit and your branch in openfisca/openfisca-core#1131! This does indeed fix most of the issues. I just made one more pass and the only warning left at this stage is a very mysterious As can be seen from the message, there is no reference whatsoever to any file or module, making this error basically impossible to fix. After a lot of research, I tried the following options, to no avail:
At this stage, I am at a complete loss as to how to fix this warning. The only way forward I see left for us is to stop treating warnings as errors and proceed, so we can finally have the doc build again and be done with this work that has been ongoing for over a month now. However, that would mean losing feedback on docstrings issues when building the doc. |
Okay, we can fix this by removing the |
This branch should now pass all tests when openfisca/openfisca-core#1131, which fixes docstrings in Core, is merged. Unfortunately, openfisca/openfisca-core#1131 is not ready for review since there are additional type linting errors introduced by it in Core. |
Switch off “nitpicky” Sphinx option Fix otherwise impossible to fix “py:obj reference target not found” error
All errors in openfisca/openfisca-core#1131 are fixed. This PR is ready for review, and the build should pass once the PR in Core is merged. Once this is merged, the |
I triggered a new build now that openfisca/openfisca-core#1131 has been merged. As planned, the build now passes 🎉 This PR is just waiting for an approval to get documentation compilation to work again, which will then enable merging all content improvements that have been waiting for a while. poke @openfisca/international-maintainers |
Updates all dependencies to latest version. Supersedes #259. Fixes incompatible Jinja version issue encountered upon installing.
In particular,
recommonmark
is obsolete and has been replaced by myst-parser, which bundlesdocutils
and parses Markdown tables natively, removing the need for two extensions and a link workaround.This PR is opened as a draft because of the following issues that are currently left to handle:
toc_tree
syntax.All warnings from latest run are listed below.