Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last item in timeline should not have bottom padding #514

Open
msnassar opened this issue Mar 3, 2023 · 2 comments
Open

Last item in timeline should not have bottom padding #514

msnassar opened this issue Mar 3, 2023 · 2 comments

Comments

@msnassar
Copy link
Contributor

msnassar commented Mar 3, 2023

Because of the bottom padding on the last item in the timeline component, an extra space appears on the page between the timeline and next component.
I think last item should not add bottom padding. Let know you thoughts?
@tibi2303
Copy link
Collaborator

tibi2303 commented Mar 27, 2023 •
edited
Loading

I guess indeed, should not have the margin bottom, still changing this now may break current implementations..

@gingapa
Copy link
Contributor

gingapa commented Apr 26, 2023

Opened a PR for this: https://github.com/digit-devs/echo-ucpkn-dev/pull/1211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@msnassar @gingapa @tibi2303