This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Upgrade parity-common deps to latest #11620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
changed the title
|
niklasad1
reviewed
Apr 10, 2020
…h/parity-ethereum into dp/chore/upgrade-parity-crypto * 'dp/chore/upgrade-parity-crypto' of github.com:paritytech/parity-ethereum: ethash: use overlapping bytes after all ethash: sneaky spaces ethash: upgrade keccak-hash
|
What's up with the change of |
Sorry, my fault, will revert. |
…h/parity-ethereum into dp/chore/upgrade-parity-crypto * 'dp/chore/upgrade-parity-crypto' of github.com:paritytech/parity-ethereum: revert submodule update
* master: Fix Goerli syncing (#11604)
niklasad1
reviewed
Apr 10, 2020
| @@ -197,21 +198,17 @@ fn hash_compute(light: &Light, full_size: usize, header_hash: &H256, nonce: u64) | |||
| // improvements, since I can't imagine that 3-5% of our runtime is taken up by catting two | |||
| // arrays together. | |||
| let mut buf: MixBuf = MixBuf { | |||
| half_mix: unsafe { | |||
niklasad1
reviewed
Apr 10, 2020
| keccak-hash = "0.4.0" | ||
| kvdb = "0.4.0" | ||
| kvdb-rocksdb = "0.6.0" | ||
| keccak-hash = "0.5.0" |
There was a problem hiding this comment.
Should probably be 0.5.1?
Fixed in Cargo.lock so it is fine to ignore.
ordian
reviewed
Apr 10, 2020
Comment on lines
+142
to
+149
| let end = hash_len + mem::size_of::<u64>(); | ||
| buf[hash_len..end].copy_from_slice(&nonce.to_ne_bytes()); | ||
|
|
||
| keccak_512::unchecked(buf.as_mut_ptr(), 64, buf.as_ptr(), 40); | ||
| keccak_512::inplace_range(&mut buf, 0..end); | ||
| buf[64..].copy_from_slice(mix_hash); | ||
|
|
||
| let mut hash = [0u8; 32]; | ||
| keccak_256::unchecked(hash.as_mut_ptr(), hash.len(), buf.as_ptr(), buf.len()); | ||
| keccak_256::write(&buf, &mut hash); |
There was a problem hiding this comment.
this change introduced a substantial regression, nothing stands out in benches paritytech/parity-common#372 though
it shouldn't be a blocker for merging this PR though, I'll work on bringing the perf back
ordian
reviewed
Apr 10, 2020
Comment on lines
-1055
to
-1063
| [[package]] | ||
| name = "error-chain" | ||
| version = "0.12.2" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "d371106cc88ffdfb1eabd7111e432da544f16f3e2d7bf1dfe8bf575f1df045cd" | ||
| dependencies = [ | ||
| "version_check", | ||
| ] | ||
|
|
|
@q9f EDIT: Sorry, spoke too early, the fix will be in another PR. |
Merged
ordian
approved these changes
Apr 11, 2020
dvdplm
added a commit
that referenced
this pull request
Apr 14, 2020
* master: Upgrade parity-common deps to latest (#11620)
dvdplm
added a commit
that referenced
this pull request
Apr 14, 2020
* master: (25 commits) Update .gitmodules (#11628) ethcore/res: activate ecip-1088 phoenix on classic (#11598) Upgrade parity-common deps to latest (#11620) Fix Goerli syncing (#11604) deps: switch to upstream ctrlc (#11617) Deduplicating crate dependencies (part 3 of n) (#11614) Deduplicating crate dependencies (part 2 of n, `slab`) (#11613) Actually save ENR on creation and modification (#11602) Activate POSDAO on xDai chain and update bootnodes (#11610) Activate on-chain randomness in POA Core (#11609) Deduplicating crate dependencies (part 1 of n) (#11606) Update enodes for POA Sokol (#11611) Remove .git folder from dogerignore file so vergen library can get build date and commit hash in the binary generatio vergen library can get build date and commit hash in the binary generation (#11608) Reduced gas cost for static calls made to precompiles EIP2046/1352 (#11583) [easy] `ethcore-bloom-journal` was renamed to `accounts-bloom` (#11605) Use serde_json to export hardcoded sync (#11601) Node Discovery v4 ENR Extension (EIP-868) (#11540) Fix compile warnings (#11595) Update version to 3.0.0-alpha.1 (#11592) ethcore/res: bump canon fork hash for mordor and kotti testnets (#11584) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethabi*crates