This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable EIP-2384 for Istanbul hard fork * Update bomb delay block number * Update ropsten.json
* tx-q: basic verification of local transactions * miner: basic test for local import * miner: info log when rejecting local txn * Hernandofmt Co-Authored-By: Hernando Castano <[email protected]> * miner: assert in a test with the concrete error type * tx-q: info! -> warn! on local tx rejection
* tx: clean up legacy eip-86 based null signature * tx: add a test for null signature rejection * tx: revert json txn changes * fix evmbin bench build * tx: put UNSIGNED_SENDER behind 'test-helpers' feature * Revert "tx: put UNSIGNED_SENDER behind 'test-helpers' feature" This reverts commit 1dde478. * tx: add comment for null_sign * even more cleanup * Revert "even more cleanup" This reverts commit be29f03.
Fix tests
ordian
previously approved these changes
Dec 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
ordian
added
the
A8-backport 🕸
Pull request is already reviewed well in another branch.
label
Dec 14, 2019
niklasad1
previously approved these changes
Dec 14, 2019
niklasad1
reviewed
Dec 14, 2019
CHANGELOG.md
Outdated
* Istanbul HF in xDai (2019-12-12) (#11299) | ||
* Istanbul HF in POA Core (2019-12-19) (#11298) | ||
* Istanbul HF in POA Sokol (2019-12-05) (#11282) | ||
* Enable EIP-2384 for ice age hard fork (#11281) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* ethcore/res: activate ecip-1061 on kotti and mordor * ethcore/res: update bootnodes for mordor
s3krit
approved these changes
Dec 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.