Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Split test specs #8424

Closed
andresilva opened this issue Apr 17, 2018 · 1 comment
Closed

Split test specs #8424

andresilva opened this issue Apr 17, 2018 · 1 comment
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust.
Milestone
2.7

Comments

@andresilva
Copy link
Contributor

#8419 (comment)

Currently we just put all test specs in the res folder regardless of where they're used. We should split https://github.com/paritytech/parity/blob/master/ethcore/src/spec/spec.rs#L809 and move each spec to the module that uses it. We should also annotate test specs with #[cfg(test)] so that the spec isn't included in the binary.
@andresilva andresilva added F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. labels Apr 17, 2018
@andresilva andresilva changed the title Split test specs among users' modules Split test specs Apr 17, 2018
@andresilva andresilva mentioned this issue Apr 17, 2018
Merged
@5chdn 5chdn added this to the 1.13 milestone Apr 25, 2018
@sorpaas sorpaas mentioned this issue May 31, 2018
Merged
@5chdn 5chdn modified the milestones: 2.1, 2.2 Jul 17, 2018
@5chdn 5chdn added this to the 2.3 milestone Sep 27, 2018
@5chdn 5chdn modified the milestones: 2.3, 2.4 Oct 29, 2018
@5chdn 5chdn modified the milestones: 2.4, 2.5 Jan 10, 2019
@5chdn 5chdn modified the milestones: 2.5, 2.6 Feb 21, 2019
@soc1c soc1c modified the milestones: 2.6, 2.7 Apr 2, 2019
@adria0
Copy link

adria0 commented Jul 27, 2020

Closing the issue due to its stale state

@adria0 adria0 closed this as completed Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.7
Development

No branches or pull requests
4 participants
@andresilva @adria0 @5chdn @soc1c