Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Allow whitelisting of tokens. #6783

Closed
MicahZoltu opened this issue Oct 16, 2017 · 20 comments
Closed

Allow whitelisting of tokens. #6783

MicahZoltu opened this issue Oct 16, 2017 · 20 comments
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. P7-nicetohave 🐕 Issue is worth doing eventually.
Milestone

Comments

@MicahZoltu
Copy link
Contributor

The recent Simolean airdrop to every Ethereum account has made it so all of my accounts/contractsin Parity now show me as having 10,000 Simoleans. This is quite annoying since they are worthless and this is really just an advertising scheme. As a user, I would like the ability to click on a token in the UI and have it blacklisted so it no longer shows up for me.

I'm worried that the whole "automatically list tokens" thing is going to become more and more problematic as advertisers realize that for a couple of dollars they can make their random worthless token show up on everyone's account in Parity (and likely other wallet UIs). I'm not sure what the best long-term solution for this is since I think we are all generally against censorship, but at the same time I think we need a way to mitigate this sort of low-cost spam.

@MicahZoltu
Copy link
Contributor Author

Note: This particular technique is clever in that it costs me ETH at the moment to clear the Simoleans out of my account. Not only do I have to pay the cost of transferring them, but I also have to pay the cost to initialize them into my account since the airdrop mechanism made it so users pay initialization costs.

@3esmit
Copy link

3esmit commented Oct 16, 2017

I'm also tired of seeing tiny bits of worthless tokens in my accounts just because some dumb marketing airdropped them, and Simolean scheme can be exploited to write anything in all Parity UI clients, even offensive words.

@5chdn 5chdn added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M7-ui P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. labels Oct 16, 2017
@5chdn 5chdn added this to the 1.9 milestone Oct 16, 2017
@5chdn
Copy link
Contributor

5chdn commented Oct 16, 2017

Yeah, we already have an idea for this. Stay tuned.

Meanwhile, I will remove spammy tokens like SIM. Just nuked it.

@5chdn 5chdn added P0-dropeverything 🌋 Everyone should address the issue now. and removed P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. labels Oct 18, 2017
@Grix
Copy link
Contributor

Grix commented Oct 20, 2017

@3esmit

and Simolean scheme can be exploited to write anything in all Parity UI clients, even offensive words.

What about using it to inject javascript code? I hope that field is sanitized in the web client.

@jacogr
Copy link
Contributor

jacogr commented Oct 20, 2017

There is no JS inject avenue. The issue with the SIM tokens, is as follows -

  1. Parity reads the Token registry
  2. I finds all tokens where balance > 0 and displays these
  3. It displays these with the balance (read from contract)

In the case of SIM it returns > 0 balance for all addresses.

@5chdn
Copy link
Contributor

5chdn commented Oct 20, 2017

Spammy tokens like Simleon and Penis won't show up if you upgrade to 1.8.1 (stay tuned for binaries in a couple of hours).

@5chdn 5chdn closed this as completed Oct 20, 2017
@radarcg
Copy link

radarcg commented Dec 17, 2017

I'm on 1.8.4 beta, and I still see the PNS token.

@joshuad31
Copy link

I'm on 1.8.4 beta and I still see the PNS token.

@radarcg
Copy link

radarcg commented Dec 27, 2017

@5chdn can this be reopened? It is still an issue.

@kirushik kirushik reopened this Dec 28, 2017
@43061b4a
Copy link

This is happening to new accounts too:

image

Version: v1.8.2-beta-1b6588c-20171025/x86_64-linux-gnu/rustc1.21.0

@remi
Copy link

remi commented Jan 1, 2018

@43061b4a Did you trying clearing your browser local storage?

window.localStorage.clear()

Did the trick for me!

@joshuad31
Copy link

joshuad31 commented Jan 1, 2018

window.localStorage.clear() - This goes where exactly? Saying things like this is like saying "we don't expect non-technical users to use our product" or "penis coin is not real just get over it"

Its gross and in very poor taste. Do something about it. Its one of the first things a user notices when using the Parity wallet and it means I can't really tell my friends to use it, its embarrassing.

@43061b4a
Copy link

43061b4a commented Jan 1, 2018

This goes in the web-developer console area. See more details here for firefox. Local storage is somewhat newer data storage mechanisms and hence browser and software may not be as mature just yet. But I agree that this is something that should be addressed.

@joshuad31
Copy link

Unable to make a connection to the Parity Secure API. To update your secure token or to generate a new one, run parity signer new-token and paste the generated token into the space below.

Ensure that both the Parity node and this machine connecting have computer clocks in-sync with each other and with a timestamp server, ensuring both successful token validation and block operations.

Pathetic

@joshuad31
Copy link

And its STILL THERE even after going to all the trouble

@43061b4a
Copy link

43061b4a commented Jan 1, 2018

What version of Parity are you running? and on what OS? Clearing storage fixed it for me, I'm running on Ubuntu.

@joshuad31
Copy link

Windows
Parity/1.8.4/1.22.1/wi
Tried on BOTH Chrome and Firefox

@5chdn
Copy link
Contributor

5chdn commented Jan 2, 2018

Are you fully synchronized?

@5chdn 5chdn added this to the 1.10 milestone Jan 5, 2018
@5chdn 5chdn mentioned this issue Jan 5, 2018
64 tasks
@5chdn 5chdn changed the title Allow blacklisting of tokens. Allow blacklisting/whitelisting of tokens. Jan 16, 2018
@vidov1
Copy link

vidov1 commented Jan 18, 2018

Those spam tokens are taking space on my display, now there are 2PR, BET, HSC, ROT, WIT... A blacklist functionality is really needed.

@5chdn 5chdn modified the milestones: 1.10, 1.11 Jan 23, 2018
@5chdn 5chdn mentioned this issue Jan 26, 2018
46 tasks
@5chdn 5chdn changed the title Allow blacklisting/whitelisting of tokens. Allow whitelisting of tokens. Feb 5, 2018
@5chdn 5chdn added P7-nicetohave 🐕 Issue is worth doing eventually. and removed P0-dropeverything 🌋 Everyone should address the issue now. labels Feb 5, 2018
@5chdn 5chdn modified the milestones: 1.11, 1.12 Mar 1, 2018
@5chdn 5chdn modified the milestones: 1.12, 1.13 Apr 24, 2018
@Tbaut
Copy link
Contributor

Tbaut commented Apr 26, 2018

Moved to parity-js/shell#80

@Tbaut Tbaut closed this as completed Apr 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Development

No branches or pull requests