Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Fix PostMessageProvider unsubscribe #568

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Fix PostMessageProvider unsubscribe #568

merged 1 commit into from
Oct 30, 2019

Conversation

axelchalon
Copy link
Contributor

close #566

Tbaut
Tbaut approved these changes Oct 30, 2019
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I could not reproduce the original issue, nevertheless things still work :)
Tested a Kovan ETH transfer

amaury1093
amaury1093 approved these changes Oct 30, 2019
View reviewed changes
Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@amaury1093 amaury1093 merged commit eb4f535 into master Oct 30, 2019
@amaury1093 amaury1093 deleted the ac-fix-unsubscribe branch October 30, 2019 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

Assignees
No one assigned
Labels
A8-looksgood
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property 'uMethod' of undefined
3 participants
@axelchalon @amaury1093 @Tbaut