Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

fix: Update to electron 5 to fix context isolation #522

Merged
merged 1 commit into from
May 8, 2019
Merged

fix: Update to electron 5 to fix context isolation #522

merged 1 commit into from
May 8, 2019

Conversation

amaury1093
Copy link
Collaborator

@amaury1093 amaury1093 commented May 8, 2019 •
edited
Loading

fixes #521

Use yarn package to test, works for me on macos

@amaury1093 amaury1093 requested a review from Tbaut May 8, 2019 09:06
@amaury1093 amaury1093 changed the title fix: Update to electron 5 fix: Update to electron 5 to fix context isolation May 8, 2019
Tbaut
Tbaut approved these changes May 8, 2019
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay works well, thanks a lot for the swift fix :)

@Tbaut Tbaut merged commit 70b339b into master May 8, 2019
@Tbaut Tbaut deleted the am-fix-loading branch May 8, 2019 11:21
@ltfschoen ltfschoen mentioned this pull request May 25, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tbaut Tbaut Tbaut approved these changes

Assignees
No one assigned
Labels
A8-looksgood
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0.3.1 (in prod) won't connect to a (running) node
2 participants
@amaury1093 @Tbaut