Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

perf: Bump light.js to use getTxByHash #492

Merged
merged 2 commits into from
Apr 9, 2019
Merged

perf: Bump light.js to use getTxByHash #492

merged 2 commits into from
Apr 9, 2019

Conversation

amaury1093
Copy link
Collaborator

This requires parity-ethereum 2.5.0. Let's wait for it to be released, and test this.

Implements openethereum/js-libs#213

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it on top of the security PR #451 the following way:

  • Merged the security branch and this branch locally.
  • I commented the postinstall script that checks and download parity in fether-electron/package.json because Parity Ethereum v2,5 isn't released yet.
  • checkout beta from Parity Ethereum (v2.5)

- cherry-picked the commit responsible for the improvement (openethereum/parity-ethereum@10e1787)
git cherry-pick 10e1787ad1aa589912991c90d65f356a097d98a7
edit: not needed anymore

  • Built and launched Parity Ethereum 2.5

Worked well for normal and Signer accounts

@amaury1093
Copy link
Collaborator Author

I just tried with yarn install && yarn electron, everything works: 2.5.0 was downloaded, and I could send a tx (which polled getTxByHash).

@Tbaut Tbaut merged commit 9fa6464 into master Apr 9, 2019
@Tbaut Tbaut deleted the am-bump-lightjs branch April 9, 2019 09:48
@Tbaut Tbaut removed the A1-onice label Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants