This repository has been archived by the owner on May 24, 2022. It is now read-only.
feat: Add Reload to taskbar menu in development only #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
approved these changes
Mar 19, 2019
| @@ -156,7 +156,7 @@ const getMenubarMenuTemplate = fetherApp => { | |||
|
|
|||
| const getContextTrayMenuTemplate = fetherApp => { | |||
| if (fetherApp.options.withTaskbar) { | |||
| const template = [ | |||
| let template = [ | |||
There was a problem hiding this comment.
Should be const here, the array is mutable, but the reference is not.
There was a problem hiding this comment.
@amaurymartiny I've pushed a commit to address your comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the development environment only, when running Fether with
yarn start, we have a known issue where a blank screen appears and we have to reload the window. On macOS and some Linux OS this is not an issue when the taskbar menu is available. However on Windows, there is no taskbar menu, so there user cannot choose "Reload" from the menu, since the menu that's shown upon right-click in the Fether window is only available in development after reloading the window.As discussed with @Tbaut, propose to add "Reload" as an item to the menu that's show when you click the taskbar icon, so it will now show:
development
Show/Hide Fether
Reload
Quit
production
Show/Hide Fether
Quit