Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

fix: Fixes #401. Add ansi-styles to fix bug. Update other dependencies #403

Merged
merged 3 commits into from
Feb 5, 2019

Conversation

ltfschoen
Copy link
Contributor

  • Fixes the error by adding ansi-styles to dependencies

  • Additional dependencies updated (unrelated to the bug)

  • Checked that it works after running rm yarn.lock; rm -rf node_modules/

  • Checked that it works with both yarn; yarn electron and yarn; yarn start

  • Checked that .dmg works on macOS and that .deb works on Ubuntu Gnome

Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! Thanks a lot

@amaury1093
Copy link
Collaborator

amaury1093 commented Feb 5, 2019

CI's machine has a weird error: fether-react: ● Test suite failed to run fether-react: Cannot find module '@babel/preset-stage-0' from '/builds/parity/fether/packages/fether-react'. Do you have any idea @ltfschoen?

Edit: not reproduceable on my machine

@amaury1093 amaury1093 merged commit dce3af6 into master Feb 5, 2019
@amaury1093 amaury1093 deleted the luke-401-fix-logger-binary branch February 5, 2019 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants