-
Notifications
You must be signed in to change notification settings - Fork 33
Add gas estimation to the postTransaction
RPC
#279
Conversation
This reverts commit 0345af0.
Should be good to go for ETH transactions, albeit dodgy code, let me know what you think. |
For future reference, if anyone is reading this PR: |
Let me know what you think about that, I could use final-form-calculate, it works as expected for ETH and tokens, but I can't get rid of a warning message: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's cleaner imo, but estimateGas()
shouldn't be called in validateAmount()
anymore.
Thanks a lot, I addressed the comments and it should look better now. No more error, token transfer also have gas in |
postTransaction
RPC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! Only some grumbles left
Thanks again, comments addressed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, found 2 more small grumbles
No problem, I think it makes a lot of sense and simplifies things quite a bit. I've tested, as always, and it looks like it works :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
👍 |
parity_postTransaction
RPC to prevent any error from the node. The node knows nothing about the transaction and does not estimate gas (too costly) so it defaults to an amount of gas that is much greater than 21000.