Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Add contextIsolation=true #497

Closed
amaury1093 opened this issue Apr 8, 2019 · 0 comments · Fixed by #518
Closed

Add contextIsolation=true #497

amaury1093 opened this issue Apr 8, 2019 · 0 comments · Fixed by #518

Comments

@amaury1093
Copy link
Collaborator

In @ltfschoen's last PR #451, we didn't add contextIsolation=true, because it required a small refactoring in an already-big PR. But according to Electron security guideline, it should be done.

The refactoring consists of:

  • using IPC for the communication between main<->preload
  • using postMessage for the communication between preload<->react

References:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant