Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Transaction Details shown prior to valid inputs #474

Closed
ltfschoen opened this issue Mar 25, 2019 · 0 comments
Closed

Transaction Details shown prior to valid inputs #474

ltfschoen opened this issue Mar 25, 2019 · 0 comments

Comments

@ltfschoen
Copy link
Contributor

In this latest PR #414, the user can click through to the Send Ether page, enter a recipient and amount of say 0.01, but then if some but not all of the necessary values are available then if you click to expand Transaction Details it shows:
Gas Limit: -1
Fee: -0.000000004 ETH
Total Amount: 0.009999996 ETH
Then soon after it may display the popup "Unable to estimate gas..."
And is likely because values.ethBalance is undefined.

So I think we need to change it to the following in fether-react/src/Send/TxForm/TxDetails/TxDetails.js:

    if (
      !estimatedTxFee ||
      !values.amount ||
      !values.chainId ||
      !values.ethBalance ||
      !values.gas ||
      !values.gasPrice ||
      !values.transactionCount ||
      !token.address
    ) {
      // Keep line break so message is centered
      return `
Missing input fields...`;
    }
ltfschoen added a commit that referenced this issue Mar 25, 2019
ltfschoen added a commit that referenced this issue Mar 25, 2019
@Tbaut Tbaut closed this as completed in 64b06d6 Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant