Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Missing Health component icon on various pages #407

Open
ltfschoen opened this issue Feb 8, 2019 · 1 comment
Open

Missing Health component icon on various pages #407

ltfschoen opened this issue Feb 8, 2019 · 1 comment

Comments

@ltfschoen
Copy link
Contributor

Status icon (i.e. <Health />) should also be on the following pages.

  • Create a new account (the first step page)
  • Import account page
  • Send Ether or Send THIBCoin transaction and password page

See #355 (comment)

For example, it's not showing on the "Create a new account" page because we're only showing th Health component on create account steps when {step > 1 ? (

@amaury1093
Copy link
Collaborator

For example, it's not showing on the "Create a new account" page because we're only showing th Health component on create account steps when {step > 1 ? (

For this special case, it's because there's this footer

screenshot 2019-02-08 at 11 51 00

This could be solved by #389.

In general, I propose to make sure all screen-related footers (like feedback button) to be confined to the bottom right, so that we show the Health status on every page.

@Tbaut Tbaut added this to the 0.5, 0.6 ... milestone Mar 8, 2019
@Tbaut Tbaut added the M7-ui label Mar 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants